Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LogMessage and move LogStabilityLevel #5633

Merged
merged 5 commits into from
Jul 13, 2022
Merged

add LogMessage and move LogStabilityLevel #5633

merged 5 commits into from
Jul 13, 2022

Conversation

codeboten
Copy link
Contributor

This change will make the func available for extensions as well.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 5, 2022
@codeboten codeboten requested review from a team and mx-psi July 5, 2022 21:57
@codecov
Copy link

codecov bot commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #5633 (0b4c317) into main (feab949) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5633   +/-   ##
=======================================
  Coverage   91.33%   91.34%           
=======================================
  Files         191      192    +1     
  Lines       11384    11393    +9     
=======================================
+ Hits        10398    10407    +9     
  Misses        786      786           
  Partials      200      200
Impacted Files Coverage Δ
component/component.go 100.00% <100.00%> (ø)
service/internal/components/components.go 100.00% <100.00%> (ø)
service/internal/pipelines/pipelines.go 95.61% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feab949...0b4c317. Read the comment docs.

mx-psi
mx-psi reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase

bogdandrutu
bogdandrutu reviewed Jul 7, 2022
View reviewed changes
component/component.go Outdated Show resolved Hide resolved
Alex Boten added 5 commits July 7, 2022 11:48
@codeboten codeboten force-pushed the codeboten/move-stability-level-logging branch from fc5e769 to 0b4c317 Compare July 7, 2022 18:52
TylerHelmuth
TylerHelmuth approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeboten codeboten merged commit 6266e5b into open-telemetry:main Jul 13, 2022
@codeboten codeboten deleted the codeboten/move-stability-level-logging branch July 13, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@bogdandrutu bogdandrutu bogdandrutu left review comments

@jpkrohling jpkrohling jpkrohling left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codeboten @jpkrohling @bogdandrutu @mx-psi @TylerHelmuth