failed on unregistered featuregate #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5660 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 191 191
Lines 11386 11398 +12
=======================================
+ Hits 10409 10421 +12
Misses 778 778
Partials 199 199
Continue to review full report at Codecov.
|
Signed-off-by: Ziqi Zhao <[email protected]>
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### 💡 Enhancements 💡 | |||
|
|
|||
| - Add `linux-ppc64le` architecture to cross build tests in CI | |||
| - Collector failed when passed an unregistered feature gate (#5660) | |||
There was a problem hiding this comment.
Please also add an entry in the Deprecated section for the deprecated Apply function
There was a problem hiding this comment.
The entry is supplied.
codeboten
reviewed
Jul 11, 2022
|
@fatsheep9146 can you also add a new test(s) that verify the collector fails to start on an unknown feature flag |
Signed-off-by: Ziqi Zhao <[email protected]>
|
@TylerHelmuth @codeboten |
Signed-off-by: Ziqi Zhao <[email protected]>
codeboten
approved these changes
Jul 12, 2022
TylerHelmuth
approved these changes
Jul 12, 2022
mx-psi
reviewed
Jul 12, 2022
Signed-off-by: Ziqi Zhao <[email protected]>
mx-psi
approved these changes
Jul 12, 2022
mx-psi
reviewed
Jul 12, 2022
Signed-off-by: Ziqi Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziqi Zhao [email protected]
Description: <Describe what has changed.
Enhance registry to support failing on unregistered featuregate
fix #5656