Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip changelog for [chore] prs #5676

Merged

Conversation

codeboten
Copy link
Contributor

Add a check in the changelog job to skip the job if the title of the PR contains [chore]. This makes it possible for a user who's change doesn't require a changelog entry and doesn't have write access to the repository to skip this check.

For now I've left the check for the "Skip Changelog" label as well, in the future, this should be removed and the label can be removed altogether.

Add a check in the changelog job to skip the job if the title of the PR contains [chore]. This makes it possible for a user who's change doesn't require a changelog entry and doesn't have write access to the repository to skip this check.

For now I've left the check for the "Skip Changelog" label as well, in the future, this should be removed and the label can be removed altogether.
@codeboten codeboten requested review from a team and bogdandrutu July 12, 2022 14:12
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #5676 (3500c05) into main (6133c82) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5676      +/-   ##
==========================================
+ Coverage   91.38%   91.44%   +0.05%     
==========================================
  Files         191      192       +1     
  Lines       11389    11416      +27     
==========================================
+ Hits        10408    10439      +31     
+ Misses        781      778       -3     
+ Partials      200      199       -1     
Impacted Files Coverage Δ
service/internal/pipelines/pipelines.go 95.61% <0.00%> (-0.15%) ⬇️
client/client.go 100.00% <0.00%> (ø)
component/component.go 100.00% <0.00%> (ø)
service/featuregate/gates.go 100.00% <0.00%> (ø)
service/internal/components/components.go 100.00% <0.00%> (ø)
exporter/loggingexporter/logging_exporter.go 88.29% <0.00%> (+0.12%) ⬆️
pdata/internal/common.go 92.59% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6133c82...3500c05. Read the comment docs.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clever solution to the issue where users can't add labels themselves. I do like keeping the Skip Changelog label for situations where the PR is not a Chore but also might not need a changelog.

.github/workflows/changelog.yml Outdated Show resolved Hide resolved
@codeboten codeboten merged commit 0509360 into open-telemetry:main Jul 15, 2022
@codeboten codeboten deleted the codeboten/skip-changelog-chore branch July 15, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants