[exporter/logging] Decouple loglevel field from level of logged messages
#5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
Jul 12, 2022
TylerHelmuth
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
I like this solution. I agree with @tigrannajaryan that being able to set only the logging exporter to debug and not the entire collector is very helpful.
Codecov Report
@@ Coverage Diff @@
## main #5678 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 192 192
Lines 11415 11416 +1
=======================================
+ Hits 10438 10439 +1
Misses 778 778
Partials 199 199
Continue to review full report at Codecov.
|
|
@open-telemetry/collector-approvers any objections to this change? |
codeboten
approved these changes
Jul 13, 2022
tigrannajaryan
pushed a commit
that referenced
this pull request
Jul 15, 2022
…#5677) Build the logger on the logging exporter's logger from the one on `TelemetrySettings`, so that the logger honors the configuration settings on `telemetry::logs` and the configuration options on `CollectorSettings.LoggingOptions`. Depends on #5678 **Link to tracking Issue:** Fixes #5652 **Documentation:** Documented the feature gate.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Make all messages from logging exporter report at info level.
Link to tracking Issue: #5677 (review)
cc @tigrannajaryan