-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to handle 402, 413, 414, 431 http error code as permanent errors in OTLP exporter #5674 #5685
Conversation
…en-telemetry#5674 - added StatusRequestEntityTooLarge (413) and StatusPaymentRequired (402) as failure permanent
@mcmho please add the appropriate unit test cases and CHANGELOG entry |
okay. will do. |
unit test is there. please help review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…en-telemetry#5674 - fixed code review comment
You also need a changelog entry for this. I don't think this would qualify as a breaking change but as an enhancement. |
…en-telemetry#5674 - added an entry in CHANGELOG.md
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Before approving, can you make sure this PR has all the cases that #5705 had? |
… errors in OTLP exporter open-telemetry#5674 - added 414 and 431 as permanent errors
Sure, it's done. |
… errors in OTLP exporter open-telemetry#5674 - change ifs to a switch statement
@bogdandrutu can you approve? |
Codecov Report
@@ Coverage Diff @@
## main #5685 +/- ##
==========================================
- Coverage 91.56% 91.54% -0.03%
==========================================
Files 192 192
Lines 11411 11426 +15
==========================================
+ Hits 10449 10460 +11
- Misses 768 771 +3
- Partials 194 195 +1
Continue to review full report at Codecov.
|
… errors in OTLP exporter open-telemetry#5674 - fixed according to code review
… errors in OTLP exporter open-telemetry#5674 - fixed build-and-test golangci-lint run
Looks good now? @bogdandrutu |
I think i have done everything now. thanks @bogdandrutu @jpkrohling @TylerHelmuth for your approval! |
"First-time contributors need a maintainer to approve running workflows. |
Description:
Collector currently does retries 402 and 413 error code. 413 is the error code for PAYLOAD TOO LARGE
and 402 is for PAYMENT REQUIRED which a user case of this would be when license token is exhausted.
These error code should be treated as permanent error in the Collector so that they won't get retried.
Link to tracking Issue:
#5674
Testing:
oltp_test.go
Documentation:
if we currently document http error code behavior, then treating 402 and 413 as permanent failure can be documented