Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] disable G112 to unblock CI #5700

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[ci] disable G112 to unblock CI #5700

merged 1 commit into from
Jul 18, 2022

Conversation

codeboten
Copy link
Contributor

Disabling G112 until #5699 has been addressed.

[ci] disable G112 to unblock CI
a7bd899 
Disabling G112 until open-telemetry#5699 has been addressed.
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 18, 2022
@codeboten codeboten requested review from a team and dmitryax July 18, 2022 18:50
TylerHelmuth
TylerHelmuth reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary solution so that builds can keep running or are we not concerned about this code?

@TylerHelmuth
Copy link
Member

Is this a temporary solution so that builds can keep running or are we not concerned about this code?

NVM you answered in the description

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #5700 (a7bd899) into main (0509360) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5700   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         192      192           
  Lines       11398    11398           
=======================================
  Hits        10433    10433           
  Misses        770      770           
  Partials      195      195

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0509360...a7bd899. Read the comment docs.

@codeboten codeboten merged commit c3a3160 into open-telemetry:main Jul 18, 2022
@codeboten codeboten deleted the codeboten/disable-g112 branch July 18, 2022 20:16
@mx-psi mx-psi mentioned this pull request Sep 14, 2022
Merged
This was referenced Sep 28, 2022
Merged
Merged
atoulme added a commit to atoulme/opentelemetry-collector that referenced this pull request Aug 7, 2024
@atoulme
Revert "[ci] disable G112 to unblock CI (open-telemetry#5700)"
eaf740d 
This reverts commit c3a3160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @TylerHelmuth @Aneurysm9