[chore] update documentation to use feature gate instead of flag #7397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Boten <[email protected]>
bogdandrutu
approved these changes
Mar 20, 2023
| 1. Change the feature flag to disable the feature by default, deprecating the flag at the same time | ||
| 1. Remove the feature and the flag | ||
| 1. Mark the feature as deprecated, add a short lived feature gate with the feature enabled by default | ||
| 1. Change the feature gate to disable the feature by default, deprecating the gate at the same time |
There was a problem hiding this comment.
"Deprecating" -> this is marking as stable correct? Also should this be a separate step since we do not allow changing the gate at that point?
There was a problem hiding this comment.
Right, I guess this should be re-written to include the stages of the gate. I was just renaming flag to gate :D
djaglowski
approved these changes
Mar 23, 2023
bogdandrutu
approved these changes
Mar 23, 2023
| 1. Change the feature flag to disable the feature by default, deprecating the flag at the same time | ||
| 1. Remove the feature and the flag | ||
| 1. Mark the feature as deprecated, add a short lived feature gate with the feature enabled by default | ||
| 1. Change the feature gate to disable the feature by default, deprecating the gate at the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.