[chore] [exporterhelper] Increase test coverage for persistent queue #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8250 +/- ##
==========================================
+ Coverage 90.18% 90.32% +0.13%
==========================================
Files 302 303 +1
Lines 15859 15904 +45
==========================================
+ Hits 14303 14365 +62
+ Misses 1261 1243 -18
- Partials 295 296 +1
☔ View full report in Codecov by Sentry. |
c752e83
to
3930908
Compare
84c4ad2
to
e11eb7b
Compare
codeboten
approved these changes
Aug 24, 2023
|
There's a test failing: |
It looks like a conflict caused by reusing the global instrument for OC. Looking into how to workaround or fix it it |
042e173
to
676366f
Compare
676366f
to
85329d9
Compare
85329d9
to
8f4a3cb
Compare
dmitryax
added a commit
that referenced
this pull request
Aug 28, 2023
`checkValueForProducer` test helper assumes that every OC metric has only one timeseries. But, since the queue metrics are defined globally, they accumulate more timeseries with different labels from different tests. This change removes that assumption. It allows having more tests for the exporter queue without breaking TestQueuedRetry_QueueMetricsReported. Ideally, we should avoid defining instruments globally or clear them up after each test. The first option would require passing the OpenCensus registry in as a public field of TelemetrySettings from the service start. The second option would require a bigger refactoring. I think we can allow several tests emitting datapoints for the global instruments for now until we migrate to OTel metrics. Fixes tests failing in #8250
Add tests covering e2e data delivery through persistent storage
8f4a3cb
to
ca19987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests covering e2e data delivery using the persistent queue