[chore] [config/confighttp] Remove loop memory aliasing in a test #8269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8269 +/- ##
==========================================
- Coverage 90.18% 90.14% -0.04%
==========================================
Files 302 302
Lines 15766 15766
==========================================
- Hits 14218 14212 -6
- Misses 1254 1259 +5
- Partials 294 295 +1 ☔ View full report in Codecov by Sentry. |
f6c552d
to
d9ecae8
Compare
To resolve a linter complain after bumping github.com/golangci/golangci-lint: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/5947424448/job/16129479734?pr=8268 ``` Error: confighttp_test.go:711:15: G601: Implicit memory aliasing in for loop. (gosec) CORS: &tt.CORSSettings, ```
d9ecae8
to
b280788
Compare
atoulme
approved these changes
Aug 23, 2023
codeboten
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve a linter complain after bumping github.com/golangci/golangci-lint: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/5947424448/job/16129479734?pr=8268