Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define guideline for components to deprecate config options #8285

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

jpkrohling
Copy link
Member

Fixes #5686

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested review from a team and dmitryax August 25, 2023 10:55
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18% 🎉

Comparison is base (26c150c) 90.18% compared to head (a4d52b8) 90.37%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8285      +/-   ##
==========================================
+ Coverage   90.18%   90.37%   +0.18%     
==========================================
  Files         302      303       +1     
  Lines       15859    15904      +45     
==========================================
+ Hits        14303    14373      +70     
+ Misses       1261     1237      -24     
+ Partials      295      294       -1     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 25, 2023
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor suggestions

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
@codeboten codeboten merged commit d0c4a25 into open-telemetry:main Aug 29, 2023
30 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define guideline for components to deprecate configuration
4 participants