-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define guideline for components to deprecate config options #8285
Define guideline for components to deprecate config options #8285
Conversation
Fixes open-telemetry#5686 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8285 +/- ##
==========================================
+ Coverage 90.18% 90.37% +0.18%
==========================================
Files 302 303 +1
Lines 15859 15904 +45
==========================================
+ Hits 14303 14373 +70
+ Misses 1261 1237 -24
+ Partials 295 294 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor suggestions
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Fixes #5686
Signed-off-by: Juraci Paixão Kröhling [email protected]