Specify grpc endpoint in otlp receiver config #531
Merged
+36
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat the default is picked up from the collector chart
There was a problem hiding this comment.
@avillela please bump the patch version of the demo chart and then run make generate-examples.
@TylerHelmuth done! |
TylerHelmuth
approved these changes
Nov 28, 2022
JaredTan95
pushed a commit
to JaredTan95/opentelemetry-helm-charts
that referenced
this pull request
Jan 19, 2023
* Specify grpc endpoint in otlp receiver config * Remove grpc.endpoint config from otlp receiver config altogether so that the default is picked up from the collector chart * Bump otel demo app chart version + update rendered example
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530
To fix this, I first rendered the k8s manifests for each scenario as follows:
and
I ran a diff of the 2 files, and noticed that
otel-demo.yamlwas missing the OTLP gRPC endpoint configuration:After adding this configuration to
values.yaml, it appeared to fix the issue.