-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] - add ingress #540
Merged
Merged
[demo] - add ingress #540
+5,622
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
# Conflicts: # charts/opentelemetry-demo/Chart.lock # charts/opentelemetry-demo/Chart.yaml # charts/opentelemetry-demo/examples/default/rendered/component.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/clusterrole.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/clusterrolebinding.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/configmap.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/deployment.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/role.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/rolebinding.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/secret.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/service.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/serviceaccount.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/tests/test-configmap.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/tests/test-role.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/tests/test-rolebinding.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/tests/test-serviceaccount.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana/tests/test.yaml # charts/opentelemetry-demo/examples/default/rendered/jaeger.yaml # charts/opentelemetry-demo/examples/default/rendered/opentelemetry-collector/configmap.yaml # charts/opentelemetry-demo/examples/default/rendered/opentelemetry-collector/deployment.yaml # charts/opentelemetry-demo/examples/default/rendered/opentelemetry-collector/service.yaml # charts/opentelemetry-demo/examples/default/rendered/opentelemetry-collector/serviceaccount.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/clusterrole.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/clusterrolebinding.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/cm.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/deploy.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/pvc.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/service.yaml # charts/opentelemetry-demo/examples/default/rendered/prometheus/serviceaccount.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
# Conflicts: # charts/opentelemetry-demo/Chart.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
# Conflicts: # charts/opentelemetry-demo/Chart.yaml # charts/opentelemetry-demo/README.md # charts/opentelemetry-demo/examples/default/rendered/component.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/values.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Linters are happy, this one is ready for review now |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
dmitryax
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @puckpuck please rebase
# Conflicts: # charts/opentelemetry-demo/Chart.yaml # charts/opentelemetry-demo/examples/default/rendered/component.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
TylerHelmuth
approved these changes
Dec 14, 2022
JaredTan95
pushed a commit
to JaredTan95/opentelemetry-helm-charts
that referenced
this pull request
Jan 19, 2023
* use Jaeger sub chart Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump collector version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add jaeger dependency Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add jaeger dependency Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update jaeger version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update for kube-state-metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress docs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * check for ingress logic Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart minor version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart minor version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * run generate-examples Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use released ingress spec Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * document ingress parameters Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress ci and examples Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
moh-osman3
pushed a commit
to moh-osman3/opentelemetry-helm-charts
that referenced
this pull request
Apr 12, 2023
* use Jaeger sub chart Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump collector version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add jaeger dependency Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add jaeger dependency Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress support Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update jaeger version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update for kube-state-metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress docs Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * check for ingress logic Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart minor version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * bump chart minor version Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * run generate-examples Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * only use released ingress spec Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * document ingress parameters Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add ingress ci and examples Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #525
Adds capability to specify Ingress(es) for each component. This follows the same pattern used for the collector chart.
The following config will create an Ingress using the default ingress controller. As with the collector chart, annotations are also supported.