Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-collector] Update clusterrole and clusterrolebinding naming #586

Merged
merged 3 commits into from
Jan 17, 2023
Merged

[opentelemetry-collector] Update clusterrole and clusterrolebinding naming #586

merged 3 commits into from
Jan 17, 2023
+52 −53

Conversation

TylerHelmuth
Copy link
Member

Fixes #585

  • Updates cluster role and cluster role binding naming logic to always default to fullname, even when a preset is creating the objects.
  • Updates clusterrole to only attempt rendering rules if there are rules preset.
  • Allow rendering rules even if clusterRole.create is not true. This allows adding extra rules to cluster roles created by presets.
  • Several cluster role and cluster role binding doc updates.

@TylerHelmuth TylerHelmuth requested a review from a team January 9, 2023 17:51
@TylerHelmuth TylerHelmuth requested a review from dmitryax as a code owner January 9, 2023 17:51
@kedare
Copy link

kedare commented Jan 10, 2023

Maybe also changes the comment on top of clusterRole.create as the current one is not true ? (it may be created even if it's false)

@TylerHelmuth TylerHelmuth force-pushed the update-clusterrole-logic branch from 752e342 to d1ecbac Compare January 10, 2023 16:33
@TylerHelmuth
Copy link
Member Author

@kedare updated the comment

@TylerHelmuth TylerHelmuth merged commit 6dfda8d into open-telemetry:main Jan 17, 2023
@TylerHelmuth TylerHelmuth deleted the update-clusterrole-logic branch January 17, 2023 18:10
@EmpireErwinKooi EmpireErwinKooi mentioned this pull request Jan 17, 2023
Merged
moh-osman3 pushed a commit to moh-osman3/opentelemetry-helm-charts that referenced this pull request Apr 12, 2023
@TylerHelmuth @moh-osman3
[opentelemetry-collector] Update clusterrole and clusterrolebinding n…
4dca0e0 
…aming (open-telemetry#586)

* Update clusterrole and clusterrolebinding naming

* update clusterRole.create comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allex1 Allex1

@dmitryax dmitryax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opentelemetry-collector] Cannot set clusterRole
3 participants
@TylerHelmuth @kedare @Allex1