Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove one of duplicated lines. #813

Merged
merged 1 commit into from
Mar 6, 2019
Merged

remove one of duplicated lines. #813

merged 1 commit into from
Mar 6, 2019

Conversation

gyunt
Copy link
Contributor

@gyunt gyunt commented Feb 3, 2019

Both results of following lines are same.

  1. envsperbatch = nenvs // nminibatches at line:160
  2. envsperbatch = nbatch_train // nsteps at line:163
    because of nbath = nenvs * nsteps and nbatch_train = nbatch // nminibatches at line:98-99.

First one is proper because it is more closer to the variable name, envsperbatch.

Thank you.

@pzhokhov pzhokhov merged commit 90d6677 into openai:master Mar 6, 2019
huiwenn pushed a commit to huiwenn/baselines that referenced this pull request Mar 20, 2019
kiku-jw pushed a commit to kiku-jw/baselines that referenced this pull request Apr 6, 2019
kkonen pushed a commit to kkonen/baselines-1 that referenced this pull request Sep 26, 2019
banerjs pushed a commit to banerjs/baselines that referenced this pull request Jul 21, 2020
* Remove custom_cartpole.py

- Remove calls to custom cartpole
- hill-a#810
- hill-a#812

* Update changelog.rst

* Update Changlog

- move changes from deprecations to documentations

* Update changelog.rst

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants