Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bdd): adding scheduler logic bdd #323

Merged
merged 4 commits into from
Jul 19, 2024
Merged

test(bdd): adding scheduler logic bdd #323

merged 4 commits into from
Jul 19, 2024

Conversation

abhilashshetty04
Copy link
Contributor

No description provided.

@abhilashshetty04 abhilashshetty04 changed the title est(bdd): adding scheduler logic bdd test(bdd): adding scheduler logic bdd Jul 9, 2024
Abhinandan-Purkait
Abhinandan-Purkait reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what is the difference between SpaceWeighted and CapacityWeighted?

tests/bdd/scheduler.feature Outdated Show resolved Hide resolved
tests/bdd/scheduler.feature Outdated Show resolved Hide resolved
tests/bdd/scheduler.feature Show resolved Hide resolved
@abhilashshetty04
Copy link
Contributor Author

Can you please explain what is the difference between SpaceWeighted and CapacityWeighted?

In SpaceWeighted, scheduler picks node which has vg with larger free space, Whereas in CapacityWeighted it picks node with vg that has least allocated capacity.

In VolumeWeighted scheduler will pick a node with vg having less number of lv.

@abhilashshetty04 abhilashshetty04 mentioned this pull request Jul 12, 2024
Closed
dsharma-dc
dsharma-dc reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@dsharma-dc dsharma-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of referring nodes like pvc-1 node or pvc-2 node etc, better define node names node1 node2 and node3 and use them as reference.

tests/bdd/scheduler.feature Show resolved Hide resolved
tests/bdd/scheduler.feature Outdated Show resolved Hide resolved
@abhilashshetty04
Copy link
Contributor Author

Instead of referring nodes like pvc-1 node or pvc-2 node etc, better define node names node1 node2 and node3 and use them as reference.

We dont know where the initial provisioning will happen. But we can predict which volume a new volume could follow. So i thought of validating with pvc-x volume node.

It could be confusing if we specify node name.

@abhilashshetty04 abhilashshetty04 merged commit ea480b6 into develop Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

@w3aman w3aman Awaiting requested review from w3aman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhilashshetty04 @Abhinandan-Purkait @dsharma-dc