-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate output_format='dict'
#1258
Conversation
duplicate of tests/test_datasets/test_dataset_functions.py::test_list_datasets
Looks good to me at this point. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1258 +/- ##
===========================================
+ Coverage 81.66% 85.51% +3.84%
===========================================
Files 38 38
Lines 5012 5343 +331
===========================================
+ Hits 4093 4569 +476
+ Misses 919 774 -145
☔ View full report in Codecov by Sentry. |
Must check results are (somewhat) complete before processing results
I think I cleared up the tests I accidentally broke after refactoring, but there are a lot of failures due to the test server state (also on develop). I would prefer to wait until we have working CI again. |
@mfeurer only |
Deprecates
output_format='dict'
:list_*
functions are called withoutput_format='dict'
,output_format='dict'
WIP: Going through unit tests I incidentally broke