Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 48813: maxinflight handler should let panicrecovery handler call NewLogged #17048

Merged
merged 1 commit into from
Oct 29, 2017
Merged

UPSTREAM: 48813: maxinflight handler should let panicrecovery handler call NewLogged #17048

merged 1 commit into from
Oct 29, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Oct 26, 2017 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2017
@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. vendor-update Touching vendor dir or related files labels Oct 26, 2017
@liggitt liggitt added the kind/bug Categorizes issue or PR as related to a bug. label Oct 26, 2017
@sttts
Copy link
Contributor

sttts commented Oct 26, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@liggitt
Copy link
Contributor Author

liggitt commented Oct 27, 2017

/retest

2 similar comments
@liggitt
Copy link
Contributor Author

liggitt commented Oct 27, 2017

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Oct 27, 2017

/retest

@mfojtik mfojtik added this to the 3.7.0 milestone Oct 27, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Oct 27, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a3a72e1 into openshift:master Oct 29, 2017
@liggitt liggitt deleted the maxinflight-panic branch November 10, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @sttts @openshift-merge-robot @openshift-bot @mfojtik @openshift-ci-robot @shyamjvs