Deployment updates in status graph #18579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fb4271
to
6e1a34e
Compare
|
/test extended_conformance_install |
1 similar comment
|
/test extended_conformance_install |
|
/lgtm thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 18437, 18546, 18550, 18579). |
openshift-merge-robot
added a commit
that referenced
this pull request
Feb 26, 2018
…ment-nodes Automatic merge from submit-queue. tags existing deployment nodes as "found" Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1544183#c3 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540560#c7 Followup to: #18579 cc @soltysh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1544183
Implements the
ExistenceCheckerinterface for Deployments and ReplicaSetswhich allows the HPA error marker to be set if it is trying to scale a deleted Deployment (or rs).
Skips standalone resources that are not found
cc @soltysh @mfojtik @deads2k