Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 65908: switch delete strategy to background deletion #20274

Merged
merged 1 commit into from
Jul 10, 2018
Merged

UPSTREAM: 65908: switch delete strategy to background deletion #20274

merged 1 commit into from
Jul 10, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 10, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2018
@deads2k
Copy link
Contributor

deads2k commented Jul 10, 2018

/lgtm

This fixes my configmap checking.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Jul 10, 2018

tests are green. No impact from the last merge. batch failed. test-cmd hangs are likely to be the cleanup in the secret doing a delete. This may help. merging.

@deads2k deads2k merged commit d5c018b into openshift:master Jul 10, 2018
@liggitt liggitt deleted the delete-background branch July 11, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants