Use BufferF32 instead of Buffer in GPU FFI example
#13058
Closed
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
approved these changes
May 24, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 27, 2024
Imported from GitHub PR openxla/xla#13058 Copybara import of the project: -- 5db8e9ecb4becd69cab0381c5142058697afadb5 by Andrey Portnoy <aportnoy@nvidia.com>: Use `BufferF32` instead of `Buffer` in GPU FFI example Merging this change closes #13058 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13058 from openxla:aportnoy/fix-ffi-docs-buffer 5db8e9ecb4becd69cab0381c5142058697afadb5 PiperOrigin-RevId: 636998665
|
I think there was a conflict when trying to merge this PR. Can you please rebase? |
ezhulenev
approved these changes
Jun 3, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jun 3, 2024
Imported from GitHub PR openxla/xla#13058 Copybara import of the project: -- 5db8e9ecb4becd69cab0381c5142058697afadb5 by Andrey Portnoy <aportnoy@nvidia.com>: Use `BufferF32` instead of `Buffer` in GPU FFI example Merging this change closes #13058 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13058 from openxla:aportnoy/fix-ffi-docs-buffer 5db8e9ecb4becd69cab0381c5142058697afadb5 PiperOrigin-RevId: 639796277
|
@akuegel interesting, typically GitHub would show when there's a merge conflict, why is it not working in this case? Also strange how GitHub is showing "Merging is blocked Merging can be performed automatically with 1 approving review." even though Eugene approved just recently. |
|
I'll try rebasing. |
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jun 4, 2024
Imported from GitHub PR openxla/xla#13058 Copybara import of the project: -- 5db8e9ecb4becd69cab0381c5142058697afadb5 by Andrey Portnoy <aportnoy@nvidia.com>: Use `BufferF32` instead of `Buffer` in GPU FFI example Merging this change closes #13058 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13058 from openxla:aportnoy/fix-ffi-docs-buffer 5db8e9ecb4becd69cab0381c5142058697afadb5 PiperOrigin-RevId: 639796277
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jun 4, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13058 from openxla:aportnoy/fix-ffi-docs-buffer 5db8e9ecb4becd69cab0381c5142058697afadb5 PiperOrigin-RevId: 639744852
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jun 4, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13058 from openxla:aportnoy/fix-ffi-docs-buffer 5db8e9ecb4becd69cab0381c5142058697afadb5 PiperOrigin-RevId: 639586878
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jun 4, 2024
Imported from GitHub PR openxla/xla#13058 Copybara import of the project: -- 5db8e9ecb4becd69cab0381c5142058697afadb5 by Andrey Portnoy <aportnoy@nvidia.com>: Use `BufferF32` instead of `Buffer` in GPU FFI example Merging this change closes #13058 PiperOrigin-RevId: 640072298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.