[XLA:CPU][oneDNN] Alias result to addend when feasible #17637
+111
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
suggested changes
Oct 29, 2024
xla/service/cpu/onednn_matmul.cc
Outdated
Comment on lines
148
to
150
| case OneDnnFusionConfig::SUM: | ||
| post_ops.append_sum(); | ||
| break; |
There was a problem hiding this comment.
CreateMatMulPrimDesc has been refactored to onednn_util.cc in #18527. Please rebase this PR?
xla/service/cpu/onednn_config.proto
Outdated
| @@ -50,6 +50,7 @@ message OneDnnFusionConfig { | |||
| ELU = 8; | |||
| RELU6 = 9; | |||
| SIGMOID = 10; | |||
| SUM = 11; | |||
There was a problem hiding this comment.
Could you please add a comment explaining that this is in-place accumulation? The name alone isn't enough to disambiguate it from BINARY_ADD.
Comment on lines
+713
to
+715
| if (kind == OneDnnFusionConfig::SUM) { | ||
| custom_call->set_output_to_operand_aliasing({{{}, {addend_idx, {}}}}); | ||
| } |
There was a problem hiding this comment.
Could you please add a comment in the code explaining why we need to set the aliasing?
There was a problem hiding this comment.
Changes in this file seem self-contained. Can we refactor it to another PR?
|
Thanks @penpornk for the review! I have added a commit to address your comments and created separate PRs for isolated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new oneDNN post-op type that will perform in-place addition whenever there is no broadcast overhead. It also includes matmul and convolution tests to verify the functionality.