Ensure that a symlinked exported venv exists and is valid.#18575
Merged
benjyw merged 2 commits intopantsbuild:mainfrom Mar 24, 2023
Merged
Ensure that a symlinked exported venv exists and is valid.#18575benjyw merged 2 commits intopantsbuild:mainfrom
benjyw merged 2 commits intopantsbuild:mainfrom
Conversation
Contributor
Author
|
Fixes #18508 |
Now, if users delete or corrupt the pex_root named cache, rerunning the export command will fix things.
9a77608 to
8085212
Compare
jsirois
approved these changes
Mar 24, 2023
Contributor
Author
Good idea, added a test. And also improved the existing test. |
Contributor
Author
|
PS I verified that the test fails on main and passes with this PR's original change. |
jsirois
approved these changes
Mar 24, 2023
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Mar 24, 2023
…d#18575) Now, if users delete or corrupt the pex_root named cache, rerunning the export command will fix things. Also updates the IT to use the non-deprecated pants cli invocation for export, i.e., enumerating the resolves you want with `--resolve=` rather than passing specs. This test was slow, so I also removed some redundancy - we didn't need to laboriously test that many tools can export. A sampling was enough. Now, with the added test, the test file as a whole runs in about the same time as previously (~100 seconds). This will be sped up further once we remove the old-style, deprecated tool lockfiles.
stuhood
pushed a commit
that referenced
this pull request
Mar 24, 2023
…ck of #18575) (#18585) Now, if users delete or corrupt the pex_root named cache, rerunning the export command will fix things. Also updates the IT to use the non-deprecated pants cli invocation for export, i.e., enumerating the resolves you want with `--resolve=` rather than passing specs. This test was slow, so I also removed some redundancy - we didn't need to laboriously test that many tools can export. A sampling was enough. Now even with the added test the test file as a whole runs in about the same time as previously (~100 seconds). This will be sped up further once we remove the old-style, deprecated tool lockfiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, if users delete or corrupt the pex_root named cache, rerunning the export
command will fix things.
Also updates the IT to use the non-deprecated pants cli invocation for export,
i.e., enumerating the resolves you want with
--resolve=rather than passing specs.This test was slow, so I also removed some redundancy - we didn't need to laboriously
test that many tools can export. A sampling was enough. Now even with the added test
the test file as a whole runs in about the same time as previously (~100 seconds).
This will be sped up further once we remove the old-style, deprecated tool lockfiles.