Restore retries for stores to remote REAPI byte stores#19737
Merged
Conversation
Contributor
Author
|
(This will have conflicts with #19711, but this one should land first, to make for easier cherrypicking.) |
d89a439 to
2d6a6ff
Compare
stuhood
approved these changes
Sep 7, 2023
Member
|
Adding |
WorkerPants
pushed a commit
that referenced
this pull request
Sep 7, 2023
This fixes #19732 by restoring the retries when storing hits retryable server failures from the REAPI remote cache server, which were lost in the #19050 refactoring. This also explicitly tests for retries, refactoring `StubCAS` to generalise `read_request_count` to expose the counts of more requests than just reads, and also consistently return a `Status::internal(...)` for the simulated errors. I think #19050 fortunately landed just after 2.17 was cut, so this regression only affects the 2.18 pre-releases.
Member
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.18.xSuccessfully opened #19798. Thanks again for your contributions! |
Contributor
Author
Oops, yes, thanks! |
huonw
added a commit
that referenced
this pull request
Sep 7, 2023
…#19737) (#19798) This fixes #19732 by restoring the retries when storing hits retryable server failures from the REAPI remote cache server, which were lost in the #19050 refactoring. This also explicitly tests for retries, refactoring `StubCAS` to generalise `read_request_count` to expose the counts of more requests than just reads, and also consistently return a `Status::internal(...)` for the simulated errors. I think #19050 fortunately landed just after 2.17 was cut, so this regression only affects the 2.18 pre-releases. Co-authored-by: Huon Wilson <huon@exoflare.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #19732 by restoring the retries when storing hits retryable server failures from the REAPI remote cache server, which were lost in the #19050 refactoring.
This also explicitly tests for retries, refactoring
StubCASto generaliseread_request_countto expose the counts of more requests than just reads, and also consistently return aStatus::internal(...)for the simulated errors.I think #19050 fortunately landed just after 2.17 was cut, so this regression only affects the 2.18 pre-releases.