Skip to content

Fetch shellcheck from vscode-shellcheck for M1 support (Cherry-pick of #19945)#19952

Merged
huonw merged 1 commit into2.17.xfrom
cherry-pick-19945-to-2.17.x
Sep 30, 2023
Merged

Fetch shellcheck from vscode-shellcheck for M1 support (Cherry-pick of #19945)#19952
huonw merged 1 commit into2.17.xfrom
cherry-pick-19945-to-2.17.x

Conversation

@WorkerPants
Copy link
Member

Fixes #18589

#18589 (comment)

Shellcheck is available from VSCode: https://github.com/vscode-shellcheck/shellcheck-binaries/releases

and this is the recommendation of shellcheck itself:

https://github.com/koalaman/shellcheck/blob/90d3172dfec30a7569f95b32479ae97af73b8b2e/README.md?plain=1#L236-L237

There are currently no official binaries for Apple Silicon, but third party builds are available via ShellCheck for Visual Studio Code.

Testing

This has fixed shellcheck in my local env without the need for rosetta.

Fixes #18589 

#18589 (comment)
> Shellcheck is available from VSCode:
https://github.com/vscode-shellcheck/shellcheck-binaries/releases
> 
> and this is the recommendation of shellcheck itself:
> 
>
https://github.com/koalaman/shellcheck/blob/90d3172dfec30a7569f95b32479ae97af73b8b2e/README.md?plain=1#L236-L237
> 
> > There are currently no official binaries for Apple Silicon, but
third party builds are available via [ShellCheck for Visual Studio
Code](https://github.com/vscode-shellcheck/shellcheck-binaries/releases).
> 

## Testing

This has fixed shellcheck in my local env without the need for rosetta.
@WorkerPants WorkerPants added this to the 2.17.x milestone Sep 28, 2023
@WorkerPants WorkerPants added the category:bugfix Bug fixes for released features label Sep 28, 2023
@WorkerPants WorkerPants requested a review from huonw September 28, 2023 23:42
@huonw huonw merged commit bdea5c6 into 2.17.x Sep 30, 2023
@huonw huonw deleted the cherry-pick-19945-to-2.17.x branch September 30, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:bugfix Bug fixes for released features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants