CODING_STANDARDS.md: add rules for bool/zend_result return types #10630
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nikic mentioned this guideline on php-internals (https://news-web.php.net/php.internals/119573), but it appears to be undocumented.
|
Thanks for this, the message itself is correct to me but let s see what other folks think of its formulation. |
|
This looks reasonable, but sometime true/false being used for success/failure can also make sense (and is already done in some place so I wouldn't blindly convert stuff from bool to zend_result) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikic mentioned this guideline on php-internals
(https://news-web.php.net/php.internals/119573), but it appears to be undocumented.