Fix Autoconf check for development versions #11532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Autoconf version includes also development patch character (for example, 2.72c), such as in unreleased Autoconf versions, this now sets proper number for checking minimum required Autoconf version.
iluuu1994
approved these changes
Jun 26, 2023
|
This is not merged yet, similarly the referenced PR is still open. Did you forget to merge them or should someone else handle the merge? :) |
|
@nielsdos yes, this and the referenced PR can be merged for PHP-8.3. I'm not sure what is our merge strategy here. I'll check otherwise later, how to merge it. I haven't checked the Git instructions on the php-src for a while now that's why... :D |
|
@petk For |
|
Misclick with the reviewer addition and removal above, sorry. Then let's do that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Autoconf version includes also development patch character (for example,
2.72c), such as in unreleased Autoconf versions, this now sets proper number for checking minimum required Autoconf version.Found at #11427