Add option to set a locale #546
Conversation
There was a problem hiding this comment.
Sometimes I really, really hate PHP... 😒
This is super confusing. At first I though this is about a rather typical non-multibyte-aware implementation, but this doesn't seem to be the case. The binary representation of the ASCII character / (the path separator) is hex 2f, so any multibyte character that has a binary representation starting with hex 2f should cause basename() to see a non-existing path separator - like ⼀, whose binary representation is hex 2f00. But this doesn't seem to be the case. basename() just truncates any multibyte character at the beginning when no multibyte-aware locale is used? And PHP developers really think this is no bug? WTF?
Thank you for your contribution! ❤️ Please address the suggested changes below and I'll merge this 👍
As mentioned in https://www.php.net/manual/en/function.basename.php both basename() and dirname() are locale aware. An incorrect locale can cause the page tree to behave in strange ways. For example the structure /über-uns |-index.md |-impressum.md could lead to the page impressum not being a child of über-uns.
|
Great, thanks for the fast reaction! |
As mentioned in https://www.php.net/manual/en/function.basename.php both
basename() and dirname() are locale aware.
An incorrect locale can cause the page tree to behave in strange ways.
For example the structure
/über-uns
|-index.md
|-impressum.md
could lead to the page impressum not being a child of über-uns.