Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versioning Scheme #22

Closed
julienmoumne opened this issue Aug 7, 2016 · 6 comments
Closed

New versioning Scheme #22

julienmoumne opened this issue Aug 7, 2016 · 6 comments
Milestone

Comments

@julienmoumne
Copy link
Member

Before June 2014, piwik-php-tracker was part of Piwik's code base and therefore followed Piwik's versioning scheme. When it became a separate project, version number went from v2.x.x to v1.0.0.

piwik-dotnet-tracker was a separate project from the beginning but followed the versioning scheme of Piwik and its tracker. This made bookkeeping convenient when porting the code base from PHP to .NET.

Current version of piwik-dotnet-tracker 2.16.0 does not correspond to either versions of Piwik and piwik-php-tracker.

piwik-dotnet-tracker should have its own version scheme since:

  • following Piwik's versioning scheme does not make sense anymore
  • following piwik-php-tracker's scheme would make it hard to merge pull requests for features unique to piwik-dotnet-tracker or submitted in a different order

piwik-dotnet-tracker would benefit from semantic versioning and autogenerated changelogs with, for example, skywinder/github-changelog-generator.

Main issues to address: 

  • determining the next version
  • dealing with the fact piwik-dotnet-tracker is a publicly published project on Nuget
  • dealing with the existing git tags
julienmoumne added a commit that referenced this issue Aug 7, 2016
@tsteur
Copy link
Member

tsteur commented Aug 7, 2016

Determining the next version:

I'd suggest to follow http://semver.org/ which also helps on deciding to determine the next version

Current version of piwik-dotnet-tracker 2.16.0 does not correspond to either versions of Piwik and piwik-php-tracker.

I would mention in the README that the version is not related to the Piwik version

In general: The version scheme for this should be independent from any other tracker and Piwik

@julienmoumne
Copy link
Member Author

Thanks for the feedback.

Do you also imply it is acceptable to start from v2.16.0 instead of finding a way to somehow reset at v1.0.0?

@tsteur
Copy link
Member

tsteur commented Aug 7, 2016

I would probably start from 2.16.0 as it would be otherwise confusing when having already released a 2.X version for this tracker.

@mattab
Copy link
Member

mattab commented Aug 8, 2016

@julienmoumne
Copy link
Member Author

See a draft of the changelog

@julienmoumne
Copy link
Member Author

New version will be 3.0.0 since the public API changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants