Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for CUDA 12.1 and CUDA 12.2 #143

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add support for CUDA 12.1 and CUDA 12.2 #143

wants to merge 3 commits into from

Conversation

pmeier
Copy link
Owner

@pmeier pmeier commented Sep 1, 2023

No description provided.

Comment on lines +181 to +182
Version("12.2"): Version("525.41"),
Version("12.1"): Version("527.41"),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lower driver version for a higher toolkit version is not a typo here, but maybe on the Nvidia side. I've asked for clarification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #143 (ecd405a) into main (ff84146) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #143   +/-   ##
=====================================
  Coverage   78.9%   78.9%           
=====================================
  Files          6       6           
  Lines        384     384           
=====================================
  Hits         303     303           
  Misses        81      81           
Flag Coverage Δ
unit 78.9% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
light_the_torch/_cb.py 90.0% <ø> (ø)

Comment on lines +181 to 183
Version("12.2"): Version("525.41"),
Version("12.1"): Version("527.41"),
Version("12.0"): Version("527.41"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeier Per the latest version of the webpage https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html

Suggested change
Version("12.2"): Version("525.41"),
Version("12.1"): Version("527.41"),
Version("12.0"): Version("527.41"),
Version("12.6"): Version("528.33"),
Version("12.5"): Version("528.33"),
Version("12.4"): Version("528.33"),
Version("12.3"): Version("528.33"),
Version("12.2"): Version("528.33"),
Version("12.1"): Version("528.33"),
Version("12.0"): Version("528.33"),

@jamesobutler
Copy link
Contributor

@pmeier This PR has been superseded by CUDA 12.1-12.6 work included in #151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants