fix(python): Fix DataFrame.to_numpy for Struct columns when structured=True
#16358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataFrame.to_numpy for struct columns when structured=TrueDataFrame.to_numpy for Struct columns when structured=True
61691c7
to
5af9758
Compare
|
Good call 👌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16358 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.01%
==========================================
Files 1406 1406
Lines 183911 183913 +2
Branches 2953 2954 +1
==========================================
- Hits 149671 149660 -11
- Misses 33727 33740 +13
Partials 513 513 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14334
Structs were just converted to an object type, but it makes much more sense for them to be nested structured arrays, which is supported by NumPy.