Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support order-by in window functions #16743

Merged
merged 3 commits into from
Jun 5, 2024
Merged

feat: Support order-by in window functions #16743

merged 3 commits into from
Jun 5, 2024

Conversation

ritchie46
Copy link
Member

Could close #8662

Might lead to a fix for #14635

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 84.13793% with 23 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (616b2e0) to head (1b3e622).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 11 Missing ⚠️
crates/polars-plan/src/logical_plan/aexpr/mod.rs 40.00% 6 Missing ⚠️
crates/polars-plan/src/dsl/expr.rs 0.00% 2 Missing ⚠️
crates/polars-plan/src/dsl/mod.rs 85.71% 2 Missing ⚠️
crates/polars-expr/src/expressions/window.rs 93.75% 1 Missing ⚠️
crates/polars-plan/src/logical_plan/format.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16743      +/-   ##
==========================================
- Coverage   81.44%   81.44%   -0.01%     
==========================================
  Files        1413     1413              
  Lines      186199   186305     +106     
  Branches     2776     2777       +1     
==========================================
+ Hits       151654   151730      +76     
- Misses      34025    34055      +30     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6f3fd8e into main Jun 5, 2024
27 checks passed
@ritchie46 ritchie46 deleted the order branch June 5, 2024 12:05
@Diadochokinetic
Copy link

Hi,

I saw in the code changes, that a parameter order_by_descending might be added. Are there any concrete plans for that? I am currently stuck over a problem, where I have to sort over two columns ascending and three descending. Couldn't figure out how to do that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ORDER BY in conjunction with over method
2 participants