Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Ensure ListPrimitiveBuilder dtype invariant is asserted #18889

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

ritchie46
Copy link
Member

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (d3f8a5c) to head (f3a89a7).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
...s-core/src/chunked_array/builder/list/primitive.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18889      +/-   ##
==========================================
- Coverage   79.89%   79.88%   -0.02%     
==========================================
  Files        1520     1520              
  Lines      206552   206555       +3     
  Branches     2906     2906              
==========================================
- Hits       165020   164997      -23     
- Misses      40984    41010      +26     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e9d835d into main Sep 24, 2024
20 of 21 checks passed
@ritchie46 ritchie46 deleted the list branch September 24, 2024 14:49
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants