Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly fetch type of full None List Series #18916

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: Properly fetch type of full None List Series #18916

merged 4 commits into from
Sep 27, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Sep 25, 2024 •
edited
Loading

Fixes #18910, #18911.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 25, 2024
@coastalwhite coastalwhite linked an issue Sep 25, 2024 that may be closed by this pull request
Diagonal concat when lazyframe other than first item contains list dtype for a column not in first item causes incompatible types error #18911
Closed
2 tasks
@coastalwhite
Copy link
Collaborator Author

Windows CI issue again

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.94077% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (2467b27) to head (9d065aa).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/column/scalar.rs 92.04% 14 Missing ⚠️
crates/polars-core/src/series/any_value.rs 83.01% 9 Missing ⚠️
crates/polars-ops/src/series/ops/duration.rs 75.00% 2 Missing ⚠️
crates/polars-io/src/utils/other.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #18916    +/-   ##
========================================
  Coverage   79.88%   79.88%            
========================================
  Files        1521     1523     +2     
  Lines      206850   206990   +140     
  Branches     2906     2906            
========================================
+ Hits       165243   165363   +120     
- Misses      41059    41079    +20     
  Partials      548      548

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d097d3c into pola-rs:main Sep 27, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fixes/scalar-list-instantiation branch September 27, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
2 participants
@coastalwhite @ritchie46