fix: Fix Expr.over with order_by did not take effect if group keys were sorted
#18947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Sep 27, 2024
| .over([col("cars")]) | ||
| .explode() |
There was a problem hiding this comment.
This query internally created a DataFrame of height 5 containing a list[_] type column of length 2 (the imploded aggregation result), which it then exploded 🤯 out to the correct height, where the correctness of the result was guaranteed because the DataFrame was sorted beforehand 😂
nameexhaustion
commented
Sep 27, 2024
| @@ -334,13 +333,8 @@ impl WindowExpr { | |||
| // no explicit aggregations, map over the groups | |||
| //`(col("x").sum() * col("y")).over("groups")` | |||
| (WindowMapping::GroupsToRows, AggState::AggregatedList(_)) => { | |||
| if sorted_keys { | |||
| if let GroupsProxy::Idx(g) = gb.get_groups() { | |||
| debug_assert!(g.is_sorted_flag()) | |||
There was a problem hiding this comment.
GroupsProxy::Idx must be explicitly mapped back to the row positions regardless of whether it was sorted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18947 +/- ##
==========================================
- Coverage 79.88% 79.87% -0.02%
==========================================
Files 1522 1522
Lines 206958 206954 -4
Branches 2906 2906
==========================================
- Hits 165322 165297 -25
- Misses 41088 41109 +21
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18943