Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return correct value for when().then().else() on structs when using first()\last() #18969

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

barak1412
Copy link
Contributor

Fixes #18961.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 27, 2024
@ritchie46
Copy link
Member

Nice, can you add a test?

@barak1412
Copy link
Contributor Author

@ritchie46

When this PR will be merged, #18930 will fix assert_frame_equal, and the existing test will verify it.
Do you want me to add a separate test?

@ritchie46
Copy link
Member

Do you want me to add a separate test?

Yes, that won't hurt. :)

@barak1412
Copy link
Contributor Author

@ritchie46

Sure! I will try get to it afternoon, if not - on sunday.
Thanks.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (71a8b05) to head (54e87a5).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18969      +/-   ##
==========================================
- Coverage   79.88%   79.86%   -0.02%     
==========================================
  Files        1522     1523       +1     
  Lines      206958   207504     +546     
  Branches     2906     2904       -2     
==========================================
+ Hits       165322   165724     +402     
- Misses      41088    41233     +145     
+ Partials      548      547       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barak1412
Copy link
Contributor Author

@ritchie46 Added test.

@ritchie46
Copy link
Member

Thank you @barak1412

@ritchie46 ritchie46 merged commit 2dbb444 into pola-rs:main Sep 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression - when().then().else() wrong result on struct
2 participants