Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure why the new temporal literal tests were sometimes failing. It appears as though sometimes the
to_datetime
anyvalue converter was being called when the input was atime
ortimedelta
.My theory is that because the superclass types were parametrized in
pytest
, and because the tests are run in parallel, theMyClass
classes were somehow colliding across threads. Thus, theMyClass(datetime)
subclass defined in the test function would be defined in one thread while thelit(MyClass(time_input))
was being run in another, and the class ancestry lookup on the rust side would find the wrong superclass. I've split the tests and given the subclasses separate names so I hope this fixes it. However, all tests have passed before, so all tests passing now doesn't necessarily mean the issue is fixed.