Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix quoting style of decimal csv output #19298

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: Fix quoting style of decimal csv output #19298

merged 1 commit into from
Oct 18, 2024

Conversation

ritchie46
Copy link
Member

fixes #19293

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 18, 2024
@ritchie46 ritchie46 merged commit 960007d into main Oct 18, 2024
22 of 24 checks passed
@ritchie46 ritchie46 deleted the quote branch October 18, 2024 09:41
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (dae6cd9) to head (940130f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-io/src/csv/write/write_impl/serializer.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19298   +/-   ##
=======================================
  Coverage   80.00%   80.01%           
=======================================
  Files        1528     1528           
  Lines      209850   209843    -7     
  Branches     2419     2419           
=======================================
+ Hits       167894   167909   +15     
+ Misses      41405    41383   -22     
  Partials      551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_csv adds quotes for null/None values in decimal columns
1 participant