Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize array and list gather #19327

Merged
merged 5 commits into from
Oct 21, 2024
Merged

perf: Optimize array and list gather #19327

merged 5 commits into from
Oct 21, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Oct 20, 2024

For numerical arrays we now gather using the leaf array and the strides. Is probably an order of magnitude faster for small/and or nested dimensions.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 94.96403% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (dbc8368) to head (7697eb0).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-arrow/src/compute/take/fixed_size_list.rs 96.96% 4 Missing ⚠️
crates/polars-arrow/src/datatypes/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19327      +/-   ##
==========================================
- Coverage   80.24%   80.23%   -0.01%     
==========================================
  Files        1523     1523              
  Lines      209524   209666     +142     
  Branches     2434     2434              
==========================================
+ Hits       168127   168234     +107     
- Misses      40842    40877      +35     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title wip: optimize array gather perf: Optimize array and list gather Oct 21, 2024
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Oct 21, 2024
@ritchie46 ritchie46 merged commit 01e801f into main Oct 21, 2024
21 of 23 checks passed
@ritchie46 ritchie46 deleted the arr_gather branch October 21, 2024 09:16
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants