-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): AssumeRole support for AWS Credential Provider #19346
Conversation
return None if not splitted else splitted[0] | ||
|
||
|
||
def _is_aws_cloud(scheme: str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored to remove the exhaustive cloud-type identification - we only need AWS and GCP for now
also more efficient to use these functions directly as we avoid double-matching
tzinfo=zoneinfo.ZoneInfo("UTC") | ||
( | ||
expiry.replace(tzinfo=zoneinfo.ZoneInfo("UTC")) | ||
if expiry.tzinfo is None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by - in case a future version of google auth adds timezone info
CredentialProviderAWS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19346 +/- ##
==========================================
+ Coverage 80.21% 80.23% +0.01%
==========================================
Files 1523 1523
Lines 209544 209579 +35
Branches 2434 2430 -4
==========================================
+ Hits 168096 168148 +52
+ Misses 40893 40878 -15
+ Partials 555 553 -2 ☔ View full report in Codecov by Sentry. |
Adds support for using an assumed role to
CredentialProviderAWS
ref #18979
ref #15838