Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depr(python): Make some parameters of dt.add_business_days keyword-only #19428

Merged
merged 2 commits into from
Oct 24, 2024
Merged

depr(python): Make some parameters of dt.add_business_days keyword-only #19428

merged 2 commits into from
Oct 24, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Oct 24, 2024 •
edited by stinodego
Loading

Closes #19390

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Oct 24, 2024
stinodego
stinodego approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it - thanks!

Good to merge if CI is green.

@stinodego stinodego changed the title chore(python): Deprecation warning for non-keyword argument of ExprDateTimeNameSpace.add_business_days chore(python): Make some parameters of dt.add_business_days keyword-only Oct 24, 2024
@stinodego stinodego changed the title chore(python): Make some parameters of dt.add_business_days keyword-only depr(python): Make some parameters of dt.add_business_days keyword-only Oct 24, 2024
@github-actions github-actions bot added the deprecation Add a deprecation warning to outdated functionality label Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (4360f9d) to head (cdfbdcc).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19428      +/-   ##
==========================================
- Coverage   80.05%   80.00%   -0.06%     
==========================================
  Files        1532     1533       +1     
  Lines      210752   210917     +165     
  Branches     2442     2442              
==========================================
+ Hits       168715   168741      +26     
- Misses      41482    41622     +140     
+ Partials      555      554       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego removed the internal An internal refactor or improvement label Oct 24, 2024
@stinodego stinodego merged commit a08b513 into pola-rs:main Oct 24, 2024
15 checks passed
@eitsupi eitsupi deleted the add_business_days-args branch October 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python: Shouldn't ExprDateTimeNameSpace.add_business_days's arguments are keyword only?
2 participants
@eitsupi @stinodego