Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IPC sink in new streaming engine #19431

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

coastalwhite
Copy link
Collaborator

ping @orlp

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 24.50980% with 77 lines in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (69c9c3a) to head (a574188).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/ipc.rs 0.00% 47 Missing ⚠️
crates/polars-lazy/src/frame/mod.rs 48.07% 27 Missing ⚠️
crates/polars-stream/src/skeleton.rs 0.00% 2 Missing ⚠️
crates/polars-mem-engine/src/planner/lp.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19431      +/-   ##
==========================================
- Coverage   80.03%   79.96%   -0.07%     
==========================================
  Files        1532     1534       +2     
  Lines      210749   210999     +250     
  Branches     2442     2442              
==========================================
+ Hits       168676   168731      +55     
- Misses      41518    41714     +196     
+ Partials      555      554       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Really nice. Can we do parquet and csv next?

@ritchie46 ritchie46 merged commit 53cdb1c into pola-rs:main Oct 25, 2024
17 of 18 checks passed
@coastalwhite coastalwhite deleted the feat/new-streaming-ipc-sink branch October 25, 2024 07:37
@c-peters c-peters added the accepted Ready for implementation label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants