feat(python): Respect include_index for pandas series
#19453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include_index for pandas series
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19453 +/- ##
==========================================
- Coverage 79.96% 79.96% -0.01%
==========================================
Files 1534 1534
Lines 211037 211039 +2
Branches 2444 2445 +1
==========================================
- Hits 168755 168753 -2
- Misses 41727 41731 +4
Partials 555 555 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Oct 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18859
For
pd.SeriesI don't think it is a good idea to ignore theinclude_indexargument if the index is the default index. Otherwise, the resulting type depends of the data.