feat: Add IPC source node for new streaming engine #19454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19454 +/- ##
==========================================
- Coverage 79.86% 79.68% -0.19%
==========================================
Files 1537 1538 +1
Lines 211923 212398 +475
Branches 2446 2446
==========================================
- Hits 169249 169241 -8
- Misses 42120 42603 +483
Partials 554 554 ☔ View full report in Codecov by Sentry. |
orlp
requested changes
Oct 29, 2024
6e9a283
to
7637a08
Compare
orlp
requested changes
Nov 1, 2024
orlp
requested changes
Nov 1, 2024
2 tasks
5571763
to
3241c9d
Compare
|
@coastalwhite There's a failure after 2 hours... a deadlock? |
3241c9d
to
dda2c83
Compare
| } | ||
| for i in 0..df.height().div_ceil(max_morsel_size) { | ||
| let morsel = df.slice((i * max_morsel_size) as i64, max_morsel_size); | ||
| let seq = MorselSeq::new(seq + i as u64); |
There was a problem hiding this comment.
I think we should initialize a MorselSeq at the start and use MorselSeq::successor() to increment this (it doesn't increment by 1)
564a2e2
to
30abe9b
Compare
This reverts commit dda2c83dc5ae2e9677ad7efdaad2b42a2b2d0ec1.
30abe9b
to
8ff9766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.