Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore quoted newlines when skipping lines in CSV #19543

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: Ignore quoted newlines when skipping lines in CSV #19543

merged 3 commits into from
Oct 31, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19535

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 31, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review October 31, 2024 08:30
@ritchie46 ritchie46 merged commit 279c4b1 into pola-rs:main Oct 31, 2024
24 of 25 checks passed
@nameexhaustion nameexhaustion deleted the csv-find-start-pos branch November 18, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delimited line breaks are ignored when skipping lines in CSV read or scan
2 participants
@nameexhaustion @ritchie46