Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix PyO3 error in CI #19545

Merged
merged 1 commit into from
Nov 1, 2024
Merged

chore: Fix PyO3 error in CI #19545

merged 1 commit into from
Nov 1, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 31, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 31, 2024
@orlp
Copy link
Collaborator Author

orlp commented Oct 31, 2024

The internal compiler panic should be resolved in the next nightly: rust-lang/rust#132395.

@stinodego
Copy link
Member

I fixed it this way: #19513

...but your way is probably nicer! So I'll close mine.

Mostly we'll have to wait for that compiler panic fix.

@orlp orlp merged commit 40f8f5d into pola-rs:main Nov 1, 2024
3 checks passed
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (6a7d140) to head (33669a3).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19545      +/-   ##
==========================================
- Coverage   80.00%   79.83%   -0.17%     
==========================================
  Files        1536     1536              
  Lines      211261   211354      +93     
  Branches     2445     2445              
==========================================
- Hits       169023   168740     -283     
- Misses      41683    42059     +376     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants