fix: Fix incorrect scan_parquet().with_row_index() with non-zero slice or with streaming collect
#19609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Nov 3, 2024
| @@ -149,6 +149,7 @@ def test_meta_tree_format(namespace_files_path: Path) -> None: | |||
| def test_meta_show_graph(namespace_files_path: Path) -> None: | |||
| e = (pl.col("foo") * pl.col("bar")).sum().over(pl.col("ham")) / 2 | |||
| dot = e.meta.show_graph(show=False, raw_output=True) | |||
| assert dot is not None | |||
There was a problem hiding this comment.
drive-by fix mypy lint on main
nameexhaustion
commented
Nov 3, 2024
| @@ -830,7 +833,7 @@ fn rg_to_dfs_par_over_rg( | |||
| if let Some(rc) = &row_index { | |||
| df.with_row_index_mut( | |||
| rc.name.clone(), | |||
| Some(row_count_start as IdxSize + rc.offset), | |||
| Some(row_count_start as IdxSize + rc.offset + slice.0 as IdxSize), | |||
There was a problem hiding this comment.
In fn rg_to_dfs*, we also add slice.0 (offset), as it may be non-zero in a negative-slice case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19609 +/- ##
==========================================
- Coverage 79.84% 79.84% -0.01%
==========================================
Files 1536 1536
Lines 211405 211456 +51
Branches 2445 2445
==========================================
+ Hits 168790 168829 +39
- Misses 42060 42072 +12
Partials 555 555 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Nov 4, 2024
tylerriccio33
pushed a commit
to tylerriccio33/polars
that referenced
this pull request
Nov 8, 2024
…ice or with streaming collect (pola-rs#19609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19607
Fixes #19606
Issues affect queries of the form:
For the negative-slice case we need to adjust the
RowIndexoffset accordingly. If we see that we need to add a row index we cannot stop early during reversed metadata scan, but instead need to scan through the metadata of the entire list of files to figure out the correct offset to begin from.The other issue with streaming parquet was just forgetting to add the current row offset.