Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sortedness was incorrectly being preserved in dt.offset_by when offsetting by non-constant durations in the timezone-naive case #19616

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #19608

…offsetting by non-constant durations in the timezone-naive case
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (0b0a914) to head (8108275).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-time/src/offset_by.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19616      +/-   ##
==========================================
- Coverage   79.96%   79.96%   -0.01%     
==========================================
  Files        1536     1536              
  Lines      211374   211374              
  Branches     2445     2445              
==========================================
- Hits       169034   169028       -6     
- Misses      41785    41791       +6     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review November 3, 2024 22:32
@ritchie46 ritchie46 merged commit 99b4a69 into pola-rs:main Nov 4, 2024
25 checks passed
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
…offsetting by non-constant durations in the timezone-naive case (pola-rs#19616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offset_by over Feb 29 creates "duplicate" dates that Polars can't de-dupe.
2 participants