Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parallel IPC sink for the new streaming engine #19622

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 4, 2024
@coastalwhite coastalwhite force-pushed the feat/new-streaming-parallel-ipc-sink branch from 4928e5d to 5ac30b9 Compare November 4, 2024 08:45
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 17.90123% with 266 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (e52a598) to head (f3e5c85).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/ipc.rs 0.00% 141 Missing ⚠️
...s/polars-stream/src/async_primitives/linearizer.rs 0.00% 46 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 28 Missing ⚠️
crates/polars-io/src/ipc/write.rs 22.22% 14 Missing ⚠️
crates/polars-arrow/src/datatypes/mod.rs 0.00% 12 Missing ⚠️
crates/polars-stream/src/pipe.rs 0.00% 12 Missing ⚠️
crates/polars-arrow/src/io/ipc/write/common.rs 86.48% 5 Missing ⚠️
crates/polars-core/src/frame/column/mod.rs 0.00% 5 Missing ⚠️
crates/polars-arrow/src/io/ipc/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19622      +/-   ##
==========================================
- Coverage   79.91%   79.85%   -0.07%     
==========================================
  Files        1536     1537       +1     
  Lines      211659   211921     +262     
  Branches     2445     2445              
==========================================
+ Hits       169156   169235      +79     
- Misses      41948    42131     +183     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/polars-stream/src/nodes/io_sources/ipc.rs Outdated Show resolved Hide resolved
@coastalwhite coastalwhite force-pushed the feat/new-streaming-parallel-ipc-sink branch from 5ac30b9 to f3e5c85 Compare November 5, 2024 17:12
@ritchie46 ritchie46 merged commit f12eff8 into pola-rs:main Nov 6, 2024
20 checks passed
@coastalwhite coastalwhite deleted the feat/new-streaming-parallel-ipc-sink branch November 6, 2024 10:54
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants