fix(python): Fix typing for SchemaDefinition #19647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs you can map a column name to 'None' to let Polars infer the data type of the given column. If you use 'None', that's what happens, but typing complains because it's not expecting the value 'None', only a valid data type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19647 +/- ##
=======================================
Coverage 79.92% 79.92%
=======================================
Files 1536 1536
Lines 211700 211700
Branches 2445 2445
=======================================
+ Hits 169199 169210 +11
+ Misses 41946 41935 -11
Partials 555 555 ☔ View full report in Codecov by Sentry. |
tylerriccio33
pushed a commit
to tylerriccio33/polars
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs you can map a column name to
Noneto let Polars infer the data type of the given column. If you useNone, that's what happens, but typing complains because it's not expecting the valueNone, only an explicit data type.