Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Series bitops to std::ops::Bit... #19673

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

coastalwhite
Copy link
Collaborator

This removes the Series::{bitand, bitor, bitxor} functions and instead moves them to the std::ops::... traits.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (4b03406) to head (a924bfb).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/series/arithmetic/bitops.rs 41.17% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19673   +/-   ##
=======================================
  Coverage   79.73%   79.74%           
=======================================
  Files        1541     1542    +1     
  Lines      212227   212187   -40     
  Branches     2449     2449           
=======================================
- Hits       169226   169198   -28     
+ Misses      42446    42434   -12     
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 169f53a into pola-rs:main Nov 7, 2024
20 checks passed
@coastalwhite coastalwhite deleted the refactor/bitops-to-core-ops branch November 7, 2024 13:00
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants